QoL: Cleaning Proto Files #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #378 +/- ##
==========================================
+ Coverage 43.89% 43.98% +0.09%
==========================================
Files 233 231 -2
Lines 8742 8642 -100
==========================================
- Hits 3837 3801 -36
+ Misses 4664 4600 -64
Partials 241 241 ☔ View full report in Codecov by Sentry. |
karnthis
reviewed
Nov 9, 2023
karnthis
requested changes
Nov 10, 2023
karnthis
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the protos are a mess. Some generated with Ignite before ignite handled data types that weren't strings, some generated by real humans who didn't have a "proto-standardization manual" in front of them.
From here on out we are adopting a protobuf styling standard following that of the Cosmos-SDK. Types will be clearly defined in Camel Case to match golang types, but fields in those types will be formatted with snake case to make them distinguishable from each other at a glance.